vigour-io / brisky-observable

fast, memory efficient observables
0 stars 2 forks source link

once behaviour with instances #71

Closed jimdebeer closed 8 years ago

jimdebeer commented 8 years ago

what do we exactly want for this?

a.once(() => {})
b = new a.Constructor()

do we want once to fire for b as well? (not really once anymore)

marcusbesjes commented 8 years ago

@jimdebeer have you decided on this?

vigourmachines commented 8 years ago

currently I am not doing updates to instances for practically purposes but may not be a good reason (is expects a real once) @youzi what do you think?

On Fri, Aug 19, 2016 at 11:19 AM, Marcus Besjes notifications@github.com wrote:

@jimdebeer https://github.com/jimdebeer have you decided on this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vigour-io/observable/issues/71#issuecomment-240969998, or mute the thread https://github.com/notifications/unsubscribe-auth/AHzW2MUGXlTW557wIHeFtYJpy5H24FyHks5qhXUjgaJpZM4JnleJ .

youzi commented 8 years ago

I think it should fire (once) for every instance.

If a (constructor) depends on this once listener, good chance b depends on it as well.

jimdebeer commented 8 years ago

ok and then a special handle in is?

On Fri, Aug 19, 2016 at 12:06 PM, Youri Daamen notifications@github.com wrote:

I think it should fire (once) for every instance.

If a (constructor) depends on this once listener, good chance b depends on it as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vigour-io/observable/issues/71#issuecomment-240979987, or mute the thread https://github.com/notifications/unsubscribe-auth/AFa1XOs1WL4nro6dKf6vtD6mel8cVNdpks5qhYAjgaJpZM4JnleJ .

jimdebeer commented 8 years ago

it is decided then!

On Fri, Aug 19, 2016 at 12:24 PM, Jim de Beer jim@vigour.io wrote:

ok and then a special handle in is?

On Fri, Aug 19, 2016 at 12:06 PM, Youri Daamen notifications@github.com wrote:

I think it should fire (once) for every instance.

If a (constructor) depends on this once listener, good chance b depends on it as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vigour-io/observable/issues/71#issuecomment-240979987, or mute the thread https://github.com/notifications/unsubscribe-auth/AFa1XOs1WL4nro6dKf6vtD6mel8cVNdpks5qhYAjgaJpZM4JnleJ .