Closed shawninder closed 9 years ago
One this is done, a new issue in that repo should be to make "getter" obsolete and remove the "getter" fields from vigour-packer-server/config.js
@jimdebeer @marcusbesjes Guys, any feedback on this? You can look at how it's made in https://github.com/vigour-io/vigour-packer-server/blob/master/config.js and https://github.com/vigour-io/vigour-packer-server/blob/master/bin/index.js
This config system should support multiple commands, maybe using the same pattern as gaston
both links are mysteriously 404's
fixed
But you'll need to be logged in as it's a private repo (otherwise you'll get 404 again)
if you can see this issue you should be able to see the files
Now exists as a separate repo: https://github.com/vigour-io/pliant Next step: have the packer use that repo and make temp.js obsolete
I like this way of handling config. I might want to use it in vigour-img, for example. Best way to achieve this would be to extract it to a separate repo. I'm just waiting for Marcus & Jim's approval of this "pattern" before going crazy and using it everywhere, in case there is a major drawback I haven't tought of.