search

vihanb / PPCG-Design

A redesign of the PPCG website
codegolf.stackexchange.com
35 stars 14 forks source link

Update to make QOD items not duplicate #105

Closed JJ-Atkinson closed 7 years ago

JJ-Atkinson commented 7 years ago

Also fixes a slight bug in the settings pane, and adds a new setting to show/hide the QOD widget. This breaks Edge and FF compatibility. Need help to fix it. Seems to be a timeout in the new code. Would fix #104

ETHproductions commented 7 years ago

I don't see any problems in Firefox 50. What exactly is going wrong?

JJ-Atkinson commented 7 years ago

@ETHproductions It seems to have something to do with getOtherTags on FF at least. I'm using Firefox 51 on windows 10. Here are some recordings:

With fix:

capture

Without:

capture2

I assume the same is true for edge.

ETHproductions commented 7 years ago

The only thing I can think of right now is if there's two tags missing when line 1013 is run, and thus it tries repeatedly but unsuccessfully to add them in. Is that a possibility?

JJ-Atkinson commented 7 years ago

I'll check into this more tomorrow, but I think that I add the attempted item is always in the list, because it is added before it is validated! Sometimes I feel real stupid. But since it works on some browsers, I'm mystified.

JJ-Atkinson commented 7 years ago

It does hang on all browsers! It didn't yesterday because it had already chose QOD content and didn't run code. Today it did while getting the new questions.

ETHproductions commented 7 years ago

Dangit, you're right, and I think I was right too... The first tag appears to keep cycling through its options forever.