vihanb / babel-plugin-wildcard

Wildcard imports import a directories JS files
MIT License
186 stars 27 forks source link

Recursive imports #11

Open RayBenefield opened 6 years ago

RayBenefield commented 6 years ago

@vihanb So I've got the initial work on recursive imports working. I'm having a hard time figuring out the best way to handle filters, but normal wildcard works just fine. I tried to avoid re-factoring too much to avoid making things unfamiliar. This is actually my first non-company open source pull request so please forgive anything I might have missed.

If you need anything changed or clarified, then please let me know.

A couple asides:

vihanb commented 6 years ago

Thanks for the PR! However from merging #10, which adds globs, some conflicts have occurred. Could you resolve these?

RayBenefield commented 6 years ago

I definitely can... I'm at a Code Retreat for most of the day, so I'll tackle it tonight.

RayBenefield commented 6 years ago

@vihanb did the rebase and @drgould's test as well as my tests seem to be working fine now.

Something to note, the deep recursive imports will also not work with file globbing right now. But root import file globbing still works. When I find some more time in the future I want to go through and refactor a bit to make sure everything is working in tandem. I'll write up some issues for each of them.

RayBenefield commented 6 years ago

@vihanb just dropping a quick reminder for a PR review in case you missed it. :)

vihanb commented 6 years ago

oh my >_< I had totally forgotten about this PR. I'll update NPM and merge tomorrow

RayBenefield commented 6 years ago

@vihanb fixed the readme @vihanb

burningTyger commented 6 years ago

Is this going to be released? Would love to use this feature in my project. Thank you for writing this plugin!

cur33 commented 6 years ago

I want to add another comment to reiterate just how useful this PR would be. @vihanb are you still maintaining this project??

vihanb commented 6 years ago

Yes I will be looking into merging this... hopefully I’ll have time this weekend but they are a few quirks I’ll have to check. I might rewrite parts of this to decouple the logic.

cur33 commented 6 years ago

That’s awesome, thanks! I tried to just use the forked repo via npm but it wasn’t working at compile time, so it would be awesome if it makes its way into the official package.

rwieruch commented 6 years ago

Any chance to get this into the project? :)

robsontenorio commented 5 years ago

A must have 👍

pmunin commented 4 years ago

is this repo still maintained?