Closed ccll closed 8 years ago
+1. I'd really love to see this functionality!
Nice idea @ccll, pulling to test it out!
Works well, just going to look at the code and see if I can pull up the Font Preview as well if the word isn't selected as in the new case.
Looking at the code changes, not sure how it isn't displaying for the second case, must be a logic bug pre-existing.
I disagree with this implementation.
- If something is selected -> convert the selection (the current behavior)
- if nothing is selected...
- if the cursor is on nothing -> do nothing (the current behavior)
- if the cursor is on a word -> select the word and convert it (added behavior)
In what case would converting a partial line be useful?
This is what happens when you attempt to do so:
I have suggested an alternative implementation here:
@ccll @Enteleform I went ahead and pulled #28 as well.
This may conflict directly with how you'd like the plugin to work @ccll. If this is the case we should examine adding a flag preference to determine full line or single word.
Most of the time I'm just converting a single word to ASCII, but I must select the word first in order to run the convert command, which is a little annoying, so I made a little tweak:
As long as this doesn't break any current behavior, just added a new 'convenient' one, so I think it can be merged safely without confusing users. Let me know if there is something I'm missing.