search

vijaycs85 / drupal-quality-checker

51 stars 37 forks source link

Update grumphp to v0.17.2 #22

Closed ghost closed 4 years ago

ghost commented 4 years ago

Fixes issue #21

johnennewdeeson commented 4 years ago

Agreed! Recently composer has stopped running any post-install-cmd scripts as I think its dying due to this error before it executes the scripts. This fixes the problem.

sgoelz commented 4 years ago

GrumPHP 0.16.2 has a bug, that is ignoring the "triggered by" section within the grumphp.yml file. As a result of this only php files are checked and .module, .inc files, etc. won't be checked by grumphp. This bug was fixed in v. 0.17.2 of grumphp. See https://github.com/phpro/grumphp/issues/715

vijaycs85 commented 4 years ago

Thanks for raising the issue. I did an update to 0.18.0