search

vijaycs85 / drupal-quality-checker

51 stars 37 forks source link

grumphp version used is not compatible with PHP 8 #35

Open ptmkenny opened 2 years ago

ptmkenny commented 2 years ago

I tried to update to Drupal 9.3 with PHP 8 this morning and got blocked because the version of grumphp used here does not support PHP 8+.

lagates commented 2 years ago

It also looks like:

sebastian/finder-facade and sebastian/phpcpd also need to be updated for PHP 8

lagates commented 2 years ago

created https://github.com/vijaycs85/drupal-quality-checker/pull/37 to update versions

malcomio commented 2 years ago

It looks like this was downgraded to support PHP <= 7 in this commit: https://github.com/vijaycs85/drupal-quality-checker/commit/9c6d10367c3a2fe88e14f0d25ea36a0c9db1d1a7

malcomio commented 2 years ago

I've created #38, which seems to work locally - @lagates what was the reason you closed #37?