search

vijaygill / wg-ui-plus

Wireguard VPN + Management Web-UI with fine-grained control over access.
MIT License
2 stars 0 forks source link

Feature/crud targetgroups target #10

Closed vijaygill closed 5 months ago

vijaygill commented 5 months ago

@thecoshman - Now basic CRUD is all finished. Tomorrow I will work on data-validation (do not allow nulls, IP addresses / networks should be properly formatted etc.) Also I will work on creating associations among Peer-Group<->Peer and Target-Group <-> Target. These are many-to-many relationships.

vijaygill commented 5 months ago

@thecoshman - can you please test this branch on your side and let me know if it is ok for merging into develop? My phone is broken and what's app does not work. So I will just have to monitor this site for notifications.

vijaygill commented 5 months ago

Ah, just noticed all edit pages need some cosmetic changes (like peer-group page) to put input elements in tables. Anyway, have a look and let me know.

thecoshman commented 5 months ago

I think it's looking good at this point. I'm tempted to say let me review the code as is, then we can merge to develop. After that, it should be smaller more focused PRs, as there's definitely things I can that need tweaking

vijaygill commented 5 months ago

I think it's looking good at this point. I'm tempted to say let me review the code as is, then we can merge to develop. After that, it should be smaller more focused PRs, as there's definitely things I can that need tweaking

Start creating issues then. We can discuss and start working on those accroding to some priority/order.