search

vijaygill / wg-ui-plus

Wireguard VPN + Management Web-UI with fine-grained control over access.
MIT License
2 stars 0 forks source link

Initial Python test for PRs #7

Closed thecoshman closed 5 months ago

thecoshman commented 5 months ago

This is WIP - but I didn't have option to make draft PR

vijaygill commented 5 months ago

@thecoshman - since you are driving this part, I will be glad if you take care of the testing side. Thanks.

thecoshman commented 5 months ago

@vijaygill yeah, I'll probably look to just get this first pr so that at least there's a test framework in place, then start to fill the gaps as other pr(s)

thecoshman commented 5 months ago

@vijaygill I think it's worth you taking a proper look at. I know the tests are failing, but that's by design, so we can see it 'blocking' PR because they are. Let me know if you've any other thoughts about how this is done. I was kinda tempted to have another root script like ./run-pytest that would start a container, do the tests and then exit.

thecoshman commented 5 months ago

It's not ready for review, but I can't mark this as a draft for some reason, maybe that's need to be enabled?

thecoshman commented 5 months ago

@vijaygill I think we're ready for proper review here now. Note that the python code changes were all to appease the linting rules