[Android Bootcamp] Image search. Please review

[vijayj]

1. used parcelable for serialization
2. Need to add 2.1 more settings 2.2 Ideally with some pagination/scrolling

/cc @nesquena @timothy1ee

[nesquena]

Hi Vijay,

I've taken a look and seems like a good start but can you please reply back to this issue when the user stories are complete (filters and pagination) by the end of the week and I will do a full code review then. Thanks!

used parcelable for serialization

Great

Need to add 2.1 more settings 2.2 Ideally with some pagination/scrolling

Check endless scrolling guide to make that easy.

[vijayj]

Nathan, Thanks for the extension. I have added the infinite scroll and the rest of settings. Please take a look

/cc @nesquena

[nesquena]

Vijay, :+1: excellent submission. A few notes after checking out the code:

• Great use of Settings to encapsulate the complexity and move it outside the controller
• Good to see you passing around serialized settings back and forth between activities
• Nice to see you used RequestParams to cleanly form the search request

You did a great job with this assignment! Also, here's provided a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

There ideally should be a better spinner that takes a collection and the selected value

Yep I could definitely invision a Spinner third party library that adds several convenience methods.

Thanks for the extension. I have added the infinite scroll and the rest of settings. Please take a look

Glad to see you got it done tonight. Excellent job.

[vijayj]

Thanks Nathan for the feedback. Really appreciate it. One thing I find different in android ( as compared to say older windows application or the new ember js) is data bindings. It would be nice to ideally bind the Settings model to Settings view so that changes are propagated by framework from view to model (instead of writing getters and setters).

[nesquena]

One thing I find different in android ( as compared to say older windows application or the new ember js) is data bindings.

I didn't mention it yet since it's badly documented but that's essentially what PreferenceFragment is for. Binding the inputs to keys in the persistence store. But in general yeah it is not quite as data binding centric as ember or other platforms. There are third party libraries that attempt some of this like AndroidBinding but none that I find particularly good (at least so far).