search

vijaymarupudi / nvim-fzf

A Lua API for using fzf in neovim.
MIT License
340 stars 13 forks source link

Since Windows support was added pipe not closing properly #34

Closed ibhagwan closed 3 years ago

ibhagwan commented 3 years ago

I believe this was added in https://github.com/vijaymarupudi/nvim-fzf/commit/5934f3bcaff204940567d1becb0c9563fac075ca, the pipe feeding lines into fzf isn't closing properly resulting in a a never ending loading indicator with sk. For some reason this does not appear to affect fzf, but even prior to this bug fzf was stopping the loading indicator regardless if I called cb(nil, fn) inside the callback to signal EOF.

This is how it looks like, look at the < right of the prompt

nvim-fzf-bug

vijaymarupudi commented 3 years ago

Should be fixed now? This was a regression, deleted a line of code I shouldn't have.

ibhagwan commented 3 years ago

Yap, works now, I was just going to suggest that line was the problem :-)

vijaymarupudi commented 3 years ago

Great!

cpkio commented 3 years ago

@ibhagwan Could you please explain how to make nvim-fzf work in Windows (it seems you made it work)? Currently it displays errors: E5108: Error executing lua ...ack\user\start\fzf-lua\lua\fzf-lua\providers\nvim.lua:290: ...a\nvim-data\site\pack\user\start\nvim-fzf\lua\fzf.lua:198: ...a\nvim-data\site\pack\user\start\nvim-fzf\lua\fzf.lua:22: bad argument #1 to 'func' (number expected, got nil)

BTW, this https://github.com/vijaymarupudi/nvim-fzf/blob/679714e140ab9b5f26731c300ecbc9108d2c9fe1/lua/fzf.lua#L111 returns nil (LibUV says it Returns: 0 or fail).

vijaymarupudi commented 3 years ago

Windows support is not complete, I need a tester to make it work, since I don't have a Windows computer. Please create a new issue if you're willing to help!

cpkio commented 3 years ago

I need a tester to make it work

I'm all yours

ibhagwan commented 3 years ago

@ibhagwan Could you please explain how to make nvim-fzf work in Windows (it seems you made it work)? Currently it displays errors: E5108: Error executing lua ...ack\user\start\fzf-lua\lua\fzf-lua\providers\nvim.lua:290: ...a\nvim-data\site\pack\user\start\nvim-fzf\lua\fzf.lua:198: ...a\nvim-data\site\pack\user\start\nvim-fzf\lua\fzf.lua:22: bad argument #1 to 'func' (number expected, got nil)

BTW, this

https://github.com/vijaymarupudi/nvim-fzf/blob/679714e140ab9b5f26731c300ecbc9108d2c9fe1/lua/fzf.lua#L111

returns nil (LibUV says it Returns: 0 or fail).

@cpkio I do not have windows as well, the issue here is even if nvim-fzf supports windows this will take quite a bit of adjustments in fzf-lua since I did not program it with Windows in mind, for that we need someone willing to make a PR, there is no way I can add support for it “blind” without having windows.