vijayvarma392 / gw_eccentricity

Defining eccentricity for GW astronomy
MIT License
20 stars 9 forks source link

Is Amp doing better than ResAmp for NR? #88

Closed vijayvarma392 closed 1 year ago

vijayvarma392 commented 2 years ago

For the NR case in the example notebook, it looks like Amp method is doing better:

image

Why? These kinds of things should be checked in the NR tests, for example by making a plot like this for all NR cases.

md-arif-shaikh commented 2 years ago

No, Amp does not do better than ResAmp, it's just that ResAmp is using extrema closer to merger which Amp does not find at all. As we have noticed earlier, using extrema close to merger gives unphysical features in spline and therefore also makes ecc non-monotonic. That's why we use num_orbits_to_exclude_before_merger. But the default value is 1 which is not good enough here. If we make num_orbits_to_exclude_before_merger=2 then they give the same result.

Screenshot from 2022-06-19 18-45-59

md-arif-shaikh commented 2 years ago

This raises two questions:

vijayvarma392 commented 2 years ago

Ok, I suggest studying all of the NR cases with num_orbits_to_exclude_before_merger = 1, 1.5, 2, to get a better idea of what works.

I personally would avoid the iterative option, I'm worried it can be a bit finicky/unstable.

md-arif-shaikh commented 2 years ago

current plots in the notebook are with value 1 and the behaviour is pretty much always that Amp looks better than ResAmp near the merger because of the reasons above. So I guess we definitely want to increase it a little bit. I will try 1.5 and 2 and see which works better