vikach / svg-edit

Automatically exported from code.google.com/p/svg-edit
0 stars 0 forks source link

Add the rev. number to the Version Information in the footer #100

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
So a screenshot, for example, will clearly show which revision is used.

The code changes so fast :-)

Would it be worth?

Original issue reported on code.google.com by worms_...@yahoo.com on 18 Aug 2009 at 8:14

GoogleCodeExporter commented 9 years ago
Dunno - every time we make a change we'd have to update that - probably not 
worth it.
 Plus the code only changes so fast on the trunk - code will be stable on released
branches.

Original comment by codedr...@gmail.com on 18 Aug 2009 at 8:19

GoogleCodeExporter commented 9 years ago
It's ok. I thought maybe it was (or could be) automatic! No worries!

Original comment by worms_...@yahoo.com on 18 Aug 2009 at 8:22

GoogleCodeExporter commented 9 years ago
Ok, wormsxulla persisted and found this:
http://code.google.com/p/support/wiki/PostCommitWebHooks

The only way I could think of using this in a positive fashion would be to have 
a
small PHP file on another web server that provides the revision number on a GET
request and accepts the JSON file that googlecode will send on a PUT request.  
We'd
then have SVG-edit pull the revision number from the URL at run-time with 
XMLHttpRequest?

Problems with this approach:  Local copies of SVG-edit would still do this 
(meaning
the wrong rev number would be shown).  Offline copies of SVG-edit would fail.

Original comment by codedr...@gmail.com on 13 Oct 2009 at 7:34

GoogleCodeExporter commented 9 years ago
Sounds good in theory. But wouldn't GET/POST requests from a local file fail 
when
attempting to access the file? Cross-domain-yada-yada and all.

Oh, and you could also use GD or something to parse the number as an image, 
then use
a reference to that. If you wanted the local thing to work.

Original comment by adeve...@gmail.com on 13 Oct 2009 at 7:45

GoogleCodeExporter commented 9 years ago
If it was an image, as explained in comment 4, would that allow to throw the 
revision
number in the svg code?

Original comment by worms_...@yahoo.com on 13 Oct 2009 at 8:08

GoogleCodeExporter commented 9 years ago
Fyrd - you're probably right.  Local copies would probably fail just like 
offline
copies.  Overall I'm not a big fan of this approach.

I'd rather have a way to get this info somehow just prior to commit and do 
something
with it.  I wonder if we could set up our environments with a script such that 
upon
running 'svn ci' it would automatically update some little file with the rev 
number?
 Of course it would require any committers of SVG-edit to have this script installed.
 And I'm not sure how this could be done in Windows...

Original comment by codedr...@gmail.com on 13 Oct 2009 at 9:00

GoogleCodeExporter commented 9 years ago
I don't really see any good way to do this because we don't have control of the 
svn
repo.  Marking WONTFIX for now.

Original comment by codedr...@gmail.com on 9 Jan 2010 at 11:04

GoogleCodeExporter commented 9 years ago
I'm back on this, after I found out this:

http://groups.google.com/group/google-code-hosting/browse_thread/thread/b11bb1e8
677e5cfb/701940348611280e?lnk=gst&q=svn+revision+-reset#701940348611280e

which explains this:

http://svnbook.red-bean.com/en/1.0/ch07s02.html#svn-ch-7-sect-2.3.4

Isn't it what we want?

Original comment by worms_...@yahoo.com on 1 Feb 2010 at 11:30

GoogleCodeExporter commented 9 years ago
Wormxulla, the problem is that the code we browse to on googlecode is not 
working
copy of the source.  Therefore $Rev$ in our source will have the revision 
number in
checked-out versions of the code (i.e. locally), but will *not* have it in the 
hosted
version on GoogleCode.  

You can verify this by bringing up SVG-edit trunk build on GoogleCode, opening 
the
Firebug console and typing:

svgCanvas.getVersion()

Then try the same thing on a local version from your hard drive.

Original comment by codedr...@gmail.com on 1 Feb 2010 at 2:46

GoogleCodeExporter commented 9 years ago
Oh yes, I forgot that bit (again!) :-(
Thanks.

Original comment by worms_...@yahoo.com on 1 Feb 2010 at 3:19