search

vikach / svg-edit

Automatically exported from code.google.com/p/svg-edit
0 stars 0 forks source link

disabling of #tools_bottom_3 by display: none; also removes the version string. #124

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
disabling of #tools_bottom_3 by display: none; also removes the version string.

I would prefer that has its own css.

#svg_editor #tools_bottom_3 {
    display: none;
    position: relative;
}

Original issue reported on code.google.com by rb.p...@gmail.com on 25 Aug 2009 at 6:45

GoogleCodeExporter commented 9 years ago 
Hello,

You want to disable the #tools_bottom_3 completely but still keep the version 
string
(#svg_editor #copyright)?

Original comment by worms_...@yahoo.com on 26 Aug 2009 at 12:44

GoogleCodeExporter commented 9 years ago 
I want that it is possible to layout the #tools_bottom_3 alone whithout the
dependency of the #copyright.

I found it by testing (display: none;) of #tools_bottom_3. That doesn't mean 
that I
permanently want to remove it. It is quite usefull!

I'd prefer that I can also set a different position of the #copyright.

Original comment by rb.p...@gmail.com on 26 Aug 2009 at 2:34

GoogleCodeExporter commented 9 years ago

Original comment by codedr...@gmail.com on 17 Sep 2009 at 3:25

GoogleCodeExporter commented 9 years ago 
I've given this a go. I think it's fixed now. How do I submit a patch? I've 
attached
it to this message.

Original comment by chov...@gmail.com on 12 Oct 2009 at 1:07

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi again. Had a thought while I was doing this. It might be good to have the
copyright block at the base of the tools_bottom rather than using normal flow. 
This
way the copyright stays in one place, no matter what tools_bottom_3 is doing.

Original comment by chov...@gmail.com on 12 Oct 2009 at 1:22

GoogleCodeExporter commented 9 years ago 
Thanks chovynz.  Next time you can do a 'svn diff > mypatch.txt' and just 
attach the
mypatch.txt file to the bug.  I've merged this in as of r801.  If everyone's 
happy
with it, let me know and I'll close this bug.  If you want to make more changes 
as
you indicate in comment #5, I'll wait.

Original comment by codedr...@gmail.com on 12 Oct 2009 at 2:54

GoogleCodeExporter commented 9 years ago 
I think you can safely close this bug as it's dealing with the tools_bottom_3 >
copyright inheritance, which has been fixed. However it might be an idea to make
another bug for copyright div CSS positioning, which is not yet resolved.

I'm happy to continue here or there. Whichever you think is best for 
communicating
each idea. (e.g. if I'm unable to work on it, someone else might need the info 
on
what to do.) Since I'm a newbie and don't yet know your structure and how you 
guys
work, I'll just go along with what you decide.

Original comment by chov...@gmail.com on 12 Oct 2009 at 10:24

GoogleCodeExporter commented 9 years ago 
Hi chovynz.  You can go ahead and open any issue you'd like.  You can work out 
issues
here or in IRC or on the mailing list - I'm happy with any and all forms of
communication :)

Closing this issue.

Original comment by codedr...@gmail.com on 13 Oct 2009 at 12:52