search

vikach / svg-edit

Automatically exported from code.google.com/p/svg-edit
0 stars 0 forks source link

Freehand/Line behaviour is not consistent with rect/circle #54

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When I draw with freehand/line the fill is not applied (only stroke is). 
When I select already drawn curve and pick the fill from the palette it is 
applied. I'm OK with not applying the fill for curves at the beginning, 
but it should be documented somewhere.

Original issue reported on code.google.com by rusn...@gmail.com on 7 Jul 2009 at 11:56

GoogleCodeExporter commented 9 years ago 
The other option is to disallow a fill value for paths/lines so that this 
distinction
is clear.  I don't think providing a fill for a path is necessary the right way 
to
go, since our scribble paths are never closed (so fill ALWAYS looks odd).

When we get into full path editing in 2.3 this is where we'll have to get 
clever.

Original comment by codedr...@gmail.com on 7 Jul 2009 at 2:47

GoogleCodeExporter commented 9 years ago 
Agreed, let's disable fill for paths for now

Original comment by rusn...@gmail.com on 7 Jul 2009 at 2:53

GoogleCodeExporter commented 9 years ago

Original comment by codedr...@gmail.com on 7 Jul 2009 at 7:10

GoogleCodeExporter commented 9 years ago 
There's a problem though:  Let's say user has selected a circle, a rect and a 
line -
should they be able to set the fill for the circle/rect with the click of a 
palette
button?

Or should the palette/picker buttons not be available if a line/path is 
included in
the selected elements?  (I think this is confusing to the user)

I guess the first option makes the most sense, but it poses some challenges to 
the
existing codebase.

Original comment by codedr...@gmail.com on 8 Jul 2009 at 3:02

GoogleCodeExporter commented 9 years ago 
Ok, I implemented as per comment #4 in r283.

Original comment by codedr...@gmail.com on 8 Jul 2009 at 4:41