search

vikas5914 / google-photos-backup

Backup photos from Google Photos using Playwright.
MIT License
211 stars 22 forks source link

fix: invalid date when parsing it from html #16

Open jaikathuria opened 7 months ago

jaikathuria commented 7 months ago

Changelog

  1. Updated the timeout because it was causing a lot of images to fail to download
  2. Created a separate method that handles the logic to get the date of the image a. This method will use 3 different options to get the date of the image
    • default which would set the value to 1/1970, if none of the ways work, this would be set
    • DateTimeOriginal which would take the values from metadata.DateTimeOriginal
    • CreateDate which would take the values from metadata.CreateDate
    • HTML which would take the values from parsing the Google Photos page
markcs commented 1 month ago

Nice Fix. @vikas5914 Can this be merged?

vikas5914 commented 1 month ago

@markcs I will do it this weekend.

skarekrow commented 1 month ago

Fixed it for me here as well, thanks @jaikathuria!