search

vikasdo / Book-Recommendation-Analysis

The E-commerce Industry is rising day by day .So for this we need a Efficient E-commerce Recommendation system . So In this Project We Try to make a recommendation system which will recommend the Items to Authors,Publishers and Retailers in such a way so that they will get a personalized Feed back from user reviews. Retailer gets more profit By Understanding the customer and focusing on their purchase pattern.
MIT License
28 stars 29 forks source link

Error in Signup #25

Closed VishvamPorwal closed 3 years ago

VishvamPorwal commented 3 years ago

Expected Behavior

There should not be an error while signing up, to resolve this in the signup form we have to add two more input fields location and age and insert them in database as well by requesting two more variables from form.

Current Behavior

When we are signing up there is an error popping up because User table has 5 columns and we are inserting only three of them leaving the other 2 (location and age) empty, hence the error is occurring telling us that we have provided None values.

Failure Information

sqlalchemy.exc.IntegrityError: (sqlite3.IntegrityError) NOT NULL constraint failed: user.location [SQL: INSERT INTO user (name, email, password, location, age) VALUES (?, ?, ?, ?, ?)] [parameters: ('username', 'username@gmail.com', 'sha.........', None, None)] (Background on this error at: http://sqlalche.me/e/13/gkpj)

Steps to Reproduce

Just try signing up.

I would like to work on this issue @vikasdo sir please assign it to me. -Thanks

VishvamPorwal commented 3 years ago

Also kindly label this issue as GSSOC21 as well.

VishvamPorwal commented 3 years ago

@vikasdo sir I have made the necessary changes as told by you and force pushed the repo( .venv files issue ) but

vikasdo:main and VishvamPorwal:signup_issue_25 are entirely different commit histories

, this is stopping me from create a pull request in an conventional way it says (https://stackoverflow.com/questions/54750229/remove-virtualenv-files-from-all-previous-commits-after-removing-from-repository) here that you have to force pull it (https://github.com/VishvamPorwal/Book-Recommendation-Analysis.git) in this rep there is a signup_issue_25 branch in which i have made changes.

VishvamPorwal commented 3 years ago

@vikasdo sir since you fixed this issue and refactored the whole codebase should I delete the previously forked repo and make new pull requests for issue#21 ??

vikasdo commented 3 years ago

Yes

On Tue, 16 Mar 2021, 18:58 VishvamPorwal, @.***> wrote:

@vikasdo https://github.com/vikasdo sir since you fixed this issue and refactored the whole codebase should I delete the previously forked repo and make new pull requests for issue#21 ??

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vikasdo/Book-Recommendation-Analysis/issues/25#issuecomment-800257625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKT3M7CPN4CZNXKGL7C6LALTD5MI3ANCNFSM4ZHZJBAA .

VishvamPorwal commented 3 years ago

Learned many things from this issue today. Thank you @vikasdo sir