search

vikashplus / robohive

A unified framework for robot learning
https://sites.google.com/view/robohive
Apache License 2.0
489 stars 82 forks source link

np.product -> np.prod for np 2.0 compatibility #147

Open vmoens opened 2 months ago

vmoens commented 2 months ago

np.product does not exist anymore, np.prod should be used instead

vmoens commented 2 months ago

@vikashplus The CI reports this thing (I think due to an H5-numpy version mismatch)

ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

Also is branch -> dev still the right way of proposing changes in robohive?

vikashplus commented 2 months ago

Seems like it. Unsure where it coming from. We don't pin to anything specific - https://github.com/vikashplus/robohive/blob/main/setup.py#L51-L67