search

vikejs / bati

Next-gen scaffolder. Get started with fully-functional apps, and choose any tool you want.
https://batijs.dev
MIT License
279 stars 14 forks source link

Broken Telefunc boilerplate? #378

Closed brillout closed 2 months ago

brillout commented 2 months ago

Describe the bug

The generated boilerplate for Telefunc seems broken.

To Reproduce

pnpm create bati --telefunc --hono

Expected behavior

A boilerplate that kind of make sense.

brillout commented 2 months ago

Ah, I omitted React/Vue/Solid that's maybe why. Let me try with a UI framework.

brillout commented 2 months ago

With React, the generated boilerplate is quite good. Although it'd be nice if pages/todo/TodoList.telefunc.ts > onNewTodo() mutates the database instead of just printing a message.

magne4000 commented 2 months ago

Related to https://github.com/vikejs/bati/discussions/263

With React, the generated boilerplate is quite good. Although it'd be nice if pages/todo/TodoList.telefunc.ts > onNewTodo() mutates the database instead of just printing a message.

It does if you select a DB like sqlite or drizzle

brillout commented 2 months ago

I'd like to use pnpm create bati --{react,vue,solid} --telefunc --hono for creating repos that will be linked next to the Vike Talk. It'b nice to have something minimal that reproduces Next.js.

magne4000 commented 2 months ago

I'd like to use pnpm create bati --{react,vue,solid} --telefunc --hono for creating repos that will be linked next to the Vike Talk. It'b nice to have something minimal that reproduces Next.js.

What would you need that is not available?

brillout commented 2 months ago

What would you need that is not available?

I think it's perfect! Just did a bit of polishing, see my PRs.

brillout commented 2 months ago

The only thing is that I'm thinking maybe we really should be removing that plain Vike boilerplate, it's quite a frankenstein :) But I don't know whether it's a lot of effort to remove :eyes:

magne4000 commented 2 months ago

I will remove it, it's half-baked and doesn't serve any real purpose. I just need to find a way to adapt the UI (I'll probably pre-select react)