search

vikejs / bati

Next-gen scaffolder. Get started with fully-functional apps, and choose any tool you want.
https://batijs.dev
MIT License
282 stars 14 forks source link

update misc #385

Closed brillout closed 2 months ago

brillout commented 2 months ago

Still a draft, let me test if I broke something.

brillout commented 2 months ago

This https://github.com/vikejs/bati/pull/385/commits/90f02ff8dd23de5c6f7d69713aafd69db988b42d doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

brillout commented 2 months ago

I didn't run the CI (my machine is probably too slow :grinning:) but I manually tested the following and seems like I didn't introduce any bug.

node packages/cli/dist/index.js --react --telefunc --hono
node packages/cli/dist/index.js --vue --telefunc --hono
node packages/cli/dist/index.js --solid --telefunc --hono

This PR is ready for review.

brillout commented 2 months ago

This 90f02ff doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

Actually, I guess the best would be to remove global.d.ts (previously vike.d.ts) if it's empty but I don't know whether it's easy to achieve.

magne4000 commented 2 months ago

This 90f02ff doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

Actually, I guess the best would be to remove global.d.ts (previously vike.d.ts) if it's empty but I don't know whether it's easy to achieve.

Shouldn't be too difficult to implement. I created an issue to follow up on this.

magne4000 commented 2 months ago

Thanks!

brillout commented 2 months ago

This 90f02ff doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

Actually, I guess the best would be to remove global.d.ts (previously vike.d.ts) if it's empty but I don't know whether it's easy to achieve.

Shouldn't be too difficult to implement. I created an issue to follow up on this.

:+1: I went ahead and reverted the comment.