Closed nitedani closed 2 months ago
You're right, fixed.
Neat. Let me know when it's ready for review.
Ready
LGTM. Feel free to merge & release.
I sent you an invitation to be a co-owner of the vike-react
package. Btw. we should update the docs:
:rocket: Niceee.
The ref forwarding is only relevant if the loaded component accepts a ref, so I wonder maybe we can return the type as if
forwardRef()
wouldn't exist, simplifying the whole TS gymnastics.I think we should update the exampleah, actually there isn't any. Maybe we should add a/clientOnly
page toexamples/full
, would be nice also for us to have something to play with.To keep things consistent, let's export it as
import { clientOnly } from vike-react/clientOnly
instead ofimport { clientOnly } from vike-react/ClientOnly
(lower-case clientOnly).