Closed lourot closed 10 months ago
👌 Good idea to use data.title
.
WDYT of 6a87d62937e25fc142b42365344a093b89cf5e3b? I think we could even do it now and release a breaking change. Making our a life a little easier for replicating this PR to vike-vue
and vike-solid
. Thoughts?
Good idea, but I suggest we make it in several PRs:
data()
hooks with useData()
(Bati relies on onBeforeRender()
+pageProps
) (FYI @magne4000)onBeforeRender()
+pageProps
and we release it as vike-react@0.4.0WDYT?
👍 Ok good idea
On Sat 23. Dec 2023 at 23:14, Aurélien Lourot @.***> wrote:
Good idea, but I suggest we make it in several PRs:
- we land this and release as @.***
- I create a PR for bati to switch to data() hooks with useData() (Bati relies on onBeforeRender()+pageProps) (FYI @magne4000 https://github.com/magne4000)
- I create a follow-up PR removing support for onBeforeRender()+ pageProps and we release it as @.***
WDYT?
— Reply to this email directly, view it on GitHub https://github.com/vikejs/vike-react/pull/50#issuecomment-1868379251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHVQRURN4AJH4QHY2IT2WTYK5JU5AVCNFSM6AAAAABBBAZV32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGM3TSMRVGE . You are receiving this because you commented.Message ID: @.***>
Let me know if you need more time to review this or if this can land. Thanks :)
👍 Let me have a closer look.
LGTM :)
useData()
to vike-reactbasic
example toexamples/onBeforeRender
basic
example from usingonBeforeRender
to usingdata
+useData()