search

vikejs / vike-vue

🔨 Vue integration for Vike
https://vike.dev/vike-vue
MIT License
33 stars 5 forks source link

feat: make Layout setting cumulative #129

Closed brillout closed 2 weeks ago

brillout commented 2 weeks ago

Main commit: https://github.com/vikejs/vike-vue/commit/346981c01b99d13ea1ef08bafa2d4630918585cb. (The other commits merely do some refactoring and add a nested layout example.)

Context:

@pdanpdan Do the changes to createVueApp.ts look good to you? I did some refactoring. Btw. I've been wondering: how about we use shallowRef() instead of ref inside createVueApp.ts?

pdanpdan commented 2 weeks ago

I would go with a merge for this one (because it works as expected) and after that start tweaking

brillout commented 2 weeks ago

These 2 can be shallowRef as far as I'm concerned, but I think ref(markRaw(x)) does the same thing - I'm not very sure, I have to check

:+1: Let me know what you find and PR welcome.

brillout commented 2 weeks ago

Let's release after we merge clientOnly().

brillout commented 2 weeks ago

Released in vike-vue@0.7.3. I decided to release it as a minor despite the breaking chagne; let me know if you disagree with that decision.