search

vikejs / vike-vue

🔨 Vue integration for Vike
https://vike.dev/vike-vue
MIT License
33 stars 5 forks source link

feat: replace usage of `ref(markRaw(...))` width `shallowRef(...)` #130

Closed pdanpdan closed 2 weeks ago

pdanpdan commented 2 weeks ago

ref https://github.com/vikejs/vike-vue/pull/129#issuecomment-2165561961

brillout commented 2 weeks ago

Neat, much cleaner. Can you remove feat:? Or replace it with perf: if you believe it's a performance boost. The only goal of the prefix is to generate CHANGELOG.md entries.

pdanpdan commented 2 weeks ago

It's more chore:

brillout commented 2 weeks ago

Yea, let's not add any prefix then.

brillout commented 2 weeks ago

We don't use chore:.

pdanpdan commented 2 weeks ago

done

brillout commented 2 weeks ago

:sparkles: