feat: rewrite root comp to use composition api

vikejs / vike-vue

🔨 Vue integration for Vike

https://vike.dev/vike-vue

MIT License

34 stars 5 forks source link

feat: rewrite root comp to use composition api #81

Closed jonaskuske closed 2 months ago

jonaskuske commented 2 months ago

See vikejs/vike#1581

Also see https://github.com/vikejs/vike/pull/1601

brillout commented 2 months ago

Very nice :sparkles: I've doubled down your improvement, cleaned the createVueApp() implementation a bit, and fixed two bugs in the process :ok_hand:

Let me know if this LGTM to you and I'll merge & release.

brillout commented 2 months ago

I went ahead and merged, but feel free to review nevertheless.

Thanks for the PR!

jonaskuske commented 2 months ago

Sorry, somehow missed your previous comment. Looks good though! 👍