search

vikejs / vike-vue

🔨 Vue integration for Vike
https://vike.dev/vike-vue
MIT License
34 stars 5 forks source link

Cumulative-packages #90

Closed 4350pChris closed 1 month ago

4350pChris commented 1 month ago

Lmk if this looks good to you

brillout commented 1 month ago

You can also just rebase: I removed the packageManager entry.

brillout commented 1 month ago

LGTM. Much cleaner now :heart_eyes:

brillout commented 1 month ago

Feel free to self merge after running pnpm run format.

brillout commented 1 month ago

FYI my thinking for resolving conflicts:

{
  value: Function
  // A "magic number" can be used for determining ordering
  order?: 'pre' | 'post' | number
  // The value always get's overridden (i.e. the value is non-cumulative)
  default?: true
  // Override all inherited values. Set to 'all' to also override values set by Vike extensions.
  clear?: true | 'all'
}

For the magic number: https://github.com/magne4000/universal-handler/discussions/4.

This can (eventually) already be implemented by vike-vue, no need for Vike core changes. But let's see if/when the need arises.

I think, as we progressively move towards the Stem vision, we'll eventually need this, let's see :eyes: