search

vikejs / vike-vue

🔨 Vue integration for Vike
https://vike.dev/vike-vue
MIT License
33 stars 5 forks source link

feat: export Vike configuration at /config #92 #93

Closed pdanpdan closed 3 weeks ago

pdanpdan commented 4 weeks ago

close #92

brillout commented 4 weeks ago

Neat :+1:

If we break down the commit in two commits, then @brillout/release-me will correctly update all the CHANGELOG.md files:

  1. A commit that only touches packages/vike-vue (without fix: commit message prefix)
  2. A commit that only touches packages/vike-{vue-query,pinia} (with fix: prefix and a second commit message line BREAKING CHANGE:)

After merging, I'll bump and release a new major for vike-{vue-query,pinia}.

On a tangent @4350pChris and myself where thinking of renaming vike-pinia to vike-vue-pinia to keep things consistent. I think we can do this at some point later.

Edit: or three commits if we want a different BREAKING CHANGE: message.

pdanpdan commented 4 weeks ago

Sure, it makes sense. Just let me check something about a hydration error in vike-vue-query before, because I was on it.

pdanpdan commented 3 weeks ago

can you please check if it looks ok as it is split now?

brillout commented 3 weeks ago

Yes, LGTM. Can I merge & release?

pdanpdan commented 3 weeks ago

You can merge. For release should we also change the name of the package first?

brillout commented 3 weeks ago

For release should we also change the name of the package first?

As you wish.

@4350pChris WDYT?

brillout commented 3 weeks ago

Maybe it would be nice to do it, so we have it behind us ✅

4350pChris commented 3 weeks ago

Go ahead and change it 👍

brillout commented 3 weeks ago

vike-vue-query@0.0.3 released.

brillout commented 3 weeks ago

I wonder why the CI wasn't triggered for this PR :thinking:

I was under the impression the following would work: https://github.com/vikejs/vike-vue/blob/b3c0cb2df9d4e30540315dc36d9a73026a243fbc/.github/workflows/ci.yml#L2-L7

brillout commented 3 weeks ago

I wonder why the CI wasn't triggered for this PR 🤔

Nevermind, it seems to be working: https://github.com/vikejs/vike-vue/pull/94.