Improve Hooks - Githubissues

vikejs / vike-vue

🔨 Vue integration for Vike

https://vike.dev/vike-vue

MIT License

33 stars 5 forks source link

Closed 4350pChris closed 3 weeks ago

4350pChris commented 3 weeks ago

4350pChris commented 3 weeks ago

@brillout I think I'll go ahead with this API if you don't have any objections.

brillout commented 3 weeks ago

:+1: LGTM. Do some users use these hooks? If yes then we should add some fix: with BREAKING CHANGE: commit.

4350pChris commented 3 weeks ago

👍 LGTM. Do some users use these hooks? If yes then we should add some fix: with BREAKING CHANGE: commit.

Like this? 589e8a4

brillout commented 3 weeks ago

Yes, I'd also mention that all packages need to be updated at the same time.

(The commit will appear in all three CHANGELOG.md because the commit touches files in all three packages.)

brillout commented 3 weeks ago

Also maybe mentioning isHydration.

4350pChris commented 3 weeks ago

Also maybe mentioning isHydration.

Lmk if you think this is enough.

brillout commented 3 weeks ago

It'll probably lead to a couple of users having to spend more time on migration, but I think it's ok.

Free free to merge & publish.