vikejs / vike

🔨 Flexible, lean, community-driven, dependable, fast Vite-based frontend framework.
https://vike.dev
MIT License
4.38k stars 350 forks source link

fix: rename STREAM to HTML_STREAM #1859

Closed brillout closed 2 months ago

brillout commented 2 months ago

@phonzammi I made it a hard breaking change, as I guess vike-solid is the only user using injectScriptsAt: 'STREAM'. Make to sure to update the +require value of vike-solid to the Vike version I'm about to release.

phonzammi commented 2 months ago

Got it 👍

phonzammi commented 2 months ago

WDYT https://github.com/vikejs/vike-solid/pull/117/commits/dc83aeb1619b64baa100606235fe86a13bed1796?

brillout commented 2 months ago

That would work, although enforcing 195 only for vike-solid-query would be a little cleaner. But it's fine either way.