fix: node_modules in .gitignore

vikejs / vike

🔨 Flexible, lean, community-driven, dependable, fast Vite-based frontend framework.

https://vike.dev

MIT License

4.4k stars 353 forks source link

Closed rtritto closed 2 months ago

rtritto commented 2 months ago

~~/node_modules/ works only in Unix OS.~~ ~~node_modules works on all OSs.~~

brillout commented 2 months ago

Being able to develop Vike on windows is a non-goal.

rtritto commented 2 months ago

@brillout With /node_modules/, the files in \test\misc\node_modules aren't ignored.

665 git changes in /test/misc/node_modules:

rtritto commented 2 months ago

/node_modules/ ignores node_modules only at root level (it's not related to OS).

Differences:

/node_modules/ --> Ignore _nodemodules folder in the root directory only
node_modules/ --> Ignore all _nodemodules directories at any depth
node_modules --> Ignores any file or directory named _nodemodules at any level

brillout commented 2 months ago

Yea.. so please be careful before creating a PR. Thank you.

rtritto commented 2 months ago

Ok, sorry for wasting your time. Please can you reopen this PR? I would change to node_modules/.