vikhyatsingh123 / SlugTerra

Hactoberfest 2020-2022 Project
https://vikhyatsingh123.github.io/SlugTerra/
MIT License
40 stars 242 forks source link

Modified some formatting and Udated #335

Closed sourabhm01 closed 10 months ago

sourabhm01 commented 10 months ago

Fixed some card disorder. Added heroes section and images. you can check below screenshot. Screenshot 2023-10-08 113619 Screenshot 2023-10-08 113547 Screenshot 2023-10-08 113723 Screenshot 2023-10-08 113645

vikhyatsingh123 commented 10 months ago

why did you change so much lines?

sourabhm01 commented 10 months ago

why did you change so much lines?

There are some slugs cards not arranged perfectly.. I arranged them and added new section of heroes of slugtera. As you can see here slugs cards are not perfectly arranged I fix them and arranged perfectly. You can see repo. And merge it

image

vikhyatsingh123 commented 10 months ago

it's fine but you have changed 3k lines. how can i review it all

vikhyatsingh123 commented 10 months ago

you can make another pr in which only change the lines that are needed

sourabhm01 commented 10 months ago

it's fine but you have changed 3k lines. how can i review it all

see the result. Not the code

sourabhm01 commented 10 months ago

you can make another pr in which only change the lines that are needed

but there are some cards that are not perfectly arranged see you your repo

vikhyatsingh123 commented 10 months ago

ok, resolve conflicts. I will see it

sourabhm01 commented 10 months ago

ok, resolve conflicts. I will see it

what should I do next?

vikhyatsingh123 commented 10 months ago

take pull from main branch. it will show conflicts. you have to resolve it then do add, commit and push the changes