search

vikiival / trap

https://trap.vik.ink/
10 stars 3 forks source link

🤖 added check for remote images #9

Closed Hladikes closed 2 years ago

Hladikes commented 2 years ago

I've added simple async check logic, to check whether a requested image is available in repository, and if not, 404.png image will be returned by default.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for trapcard ready!

🔨 Explore the source changes: 4e30624fb9bd6a2feecd23d33f3a85cb44056eae

🔍 Inspect the deploy log: https://app.netlify.com/sites/trapcard/deploys/6206d0ddebb70c00076a2377

😎 Browse the preview: https://deploy-preview-9--trapcard.netlify.app

vikiival commented 2 years ago

LGTM just thinking that we should not force redirect 404 images :) Because you know. cache

Hladikes commented 2 years ago

I don't think we have that many options, when it comes to telling the user, that the requested image is not available/does not exist 🤔 Especially in discord conversations