viking-gps / viking

Viking is a free/open source program to manage GPS data (inc GPX, FIT, TCX and KML files). You can import and plot tracks, routes and waypoints, show OpenStreetMaps (OSM), Bing Aerial and other maps, generate Mapnik maps, geotag images, make new tracks, routes and waypoints, see real-time GPS position, etc. It is written mostly in C with GTK
http://sourceforge.net/projects/viking/
GNU General Public License v2.0
230 stars 56 forks source link

Have zoom icon print error message #291

Closed jidanni closed 2 months ago

jidanni commented 3 months ago

See also https://github.com/viking-gps/viking/issues/290 .

Hit the "plus" icon, until one cannot zoom in further. Well it should print a message "maximum zoom reached", instead of seeming broken.

OK, maybe print it upon the second failed click, or keyboard zoom, so we slower-learner users will know what is wrong, (while smarter users will know right away themselves, and stop clicking in vain.)

In fact the zoom icons don't seem to change color to indicate "don't bother pressing me again".

rnorris commented 3 months ago

It can certainly be easily improved with suitable maximum zoomed out/in reached messages on keyboard shortcut and menu invoked actions.

However, to properly enable/disable zoom icons - is somewhat more involved - since it means tracking all methods zooming (including scroll events, specific zoom level requests, multiple clicking and so on), to ensure the menu action buttons are suitably enabled.

So, I'm hesitant to do the latter in case of introducing errors - or will simply take longer to resolve to including testing various potential failure points.

jidanni commented 3 months ago

All I know is on https://www.openstreetmap.org/ it is quite obvious when no more zooming will work, as the button has changed color, so lack of error message can be forgiven.

rnorris commented 2 months ago

Improved with suitable maximum zoomed out/in reached messages on keyboard shortcut and menu invoked actions.

However properly enable/disable zoom icons is left for future improvements