search

viking-sudo-rm / rusty-dawg

Rust library for indexing and quickly searching large pretraining corpora
https://arxiv.org/abs/2406.13069
MIT License
17 stars 2 forks source link

Clean up graph subpackage #46

Open viking-sudo-rm opened 1 year ago

viking-sudo-rm commented 1 year ago

The structure of the code could be cleaner:

1 Flatten graph::avl_graph subpackage into graph

  1. Move graph::memory_backing to memory_backing
  2. Generics order for Dawg<E, N> should match Graph<N, E> (and rename W -> N)

There are probably lots of other opportunities to improve readability

viking-sudo-rm commented 1 year ago

Also, there is now a weird situation in the design where MemoryBacking as a type specifies the memory backing of the graph, but mb: MemoryBacking acts as like a config for the graph?

Could probably be refactored/simplified