vikinganalytics / daeploy-issues

0 stars 0 forks source link

rename docker_run_args in ConnectorBase to support additional container backends #13

Closed OskarLiew closed 3 years ago

OskarLiew commented 3 years ago

We have talked about introducing additional container backends, for this we should use the ConnectorBase class. In it, create_service is defined with a docker_run_args argument, which should probably be renamed to run_args to make more sense once we add other backends.

Should we also add *args and **kwargs to the connectors? I'm not sure what the best practice is with abstract classes.