vikinganalytics / mvg

Repository for python library supporting Viking Analytics Multiviz Engine API
Apache License 2.0
4 stars 2 forks source link

add pagination to list_measurments() #191

Closed tuix closed 1 year ago

tuix commented 1 year ago

Description

Include a summary of this pull request

New dependencies: (Added to requirements_*.txt)

Fixes # (potential issues that are fixed by this PR)

Type of Change

Checklist

Requirements

tuix commented 1 year ago

Nice Mohsen! A few small suggestions that you can choose to ignore and a typo.

all good points. all fixed in ea927113b4790226342e15f0630e54585ed498ce

codecov[bot] commented 1 year ago

Codecov Report

Base: 71.37% // Head: 71.74% // Increases project coverage by +0.37% :tada:

Coverage data is based on head (40724e1) compared to base (702af15). Patch coverage: 86.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #191 +/- ## ========================================== + Coverage 71.37% 71.74% +0.37% ========================================== Files 11 11 Lines 814 846 +32 ========================================== + Hits 581 607 +26 - Misses 233 239 +6 ``` | [Impacted Files](https://codecov.io/gh/vikinganalytics/mvg/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics) | Coverage Δ | | |---|---|---| | [mvg/mvg.py](https://codecov.io/gh/vikinganalytics/mvg/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics#diff-bXZnL212Zy5weQ==) | `87.91% <86.66%> (-0.81%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.