vikinganalytics / mvg

Repository for python library supporting Viking Analytics Multiviz Engine API
Apache License 2.0
4 stars 2 forks source link

Remove timestamps key from inputs #209

Closed vnadhan closed 1 year ago

vnadhan commented 1 year ago

Description

Include a summary of this pull request

New dependencies: (Added to requirements_*.txt)

Fixes # (potential issues that are fixed by this PR)

Type of Change

Checklist

Requirements

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9856de0) 73.67% compared to head (8dc7ada) 73.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #209 +/- ## ======================================= Coverage 73.67% 73.67% ======================================= Files 12 12 Lines 942 942 ======================================= Hits 694 694 Misses 248 248 ``` | [Impacted Files](https://codecov.io/gh/vikinganalytics/mvg/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics) | Coverage Δ | | |---|---|---| | [mvg/mvg.py](https://codecov.io/gh/vikinganalytics/mvg/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics#diff-bXZnL212Zy5weQ==) | `90.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vnadhan commented 1 year ago

This PR does not have a breaking change. It was created to remove the reference to timestamps in inputs key of analysis results. The timestamps key was removed in the backend through the PR https://github.com/vikinganalytics/vibium-cloud/pull/793. In MVG, the timestamps key is referenced only in the tests.

It looks like the mock data of analysis results in the MVG repository is outdated. This PR should instead make sure the structure of all stub data conforms with the structure defined in the backend.