vikinganalytics / mvg

Repository for python library supporting Viking Analytics Multiviz Engine API
Apache License 2.0
4 stars 2 forks source link

Fixes for paginated measurements requests #213

Closed pro100watt closed 1 year ago

pro100watt commented 1 year ago

Description

Paginated requests list_tabular_measurements and list_measurements did not take into account the max_measurements_pagination_limit and max_timestamps_pagination_limit config parameters from vibium-cloud.

Fixes # (potential issues that are fixed by this PR)

Type of Change

Checklist

Requirements

vnadhan commented 1 year ago

Under review.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.33 :tada:

Comparison is base (9856de0) 73.67% compared to head (501d2b6) 74.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #213 +/- ## ========================================== + Coverage 73.67% 74.00% +0.33% ========================================== Files 12 12 Lines 942 954 +12 ========================================== + Hits 694 706 +12 Misses 248 248 ``` | [Impacted Files](https://app.codecov.io/gh/vikinganalytics/mvg/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics) | Coverage Δ | | |---|---|---| | [mvg/mvg.py](https://app.codecov.io/gh/vikinganalytics/mvg/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics#diff-bXZnL212Zy5weQ==) | `89.13% <68.18%> (-0.87%)` | :arrow_down: | | [mvg/utils/response\_processing.py](https://app.codecov.io/gh/vikinganalytics/mvg/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vikinganalytics#diff-bXZnL3V0aWxzL3Jlc3BvbnNlX3Byb2Nlc3NpbmcucHk=) | `87.23% <100.00%> (+9.96%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.