search

vikktorn / ExampleCountryPicker

Android Country, State/Region, City picker
9 stars 4 forks source link

option to change json data #4

Open hvar90 opened 5 years ago

hvar90 commented 5 years ago

i think would be great an option to change the Json data because the current data is very incomplete also an option to connect cities by country_id would be great and only to have two pickers for country and city

vikktorn commented 5 years ago

Hello I think about that, but there is many countries that are splited by states and regions and few of my clients exactly search for this kind of picker and connections, so because of that I make it in this way

Viktor Nesic

On Thu, Apr 11, 2019, 3:47 PM Heberth vargas Tello notifications@github.com wrote:

i think would be great an option to change the Json data because the current data is very incomplete also an option to connect cities by country_id would be great and only to have two pickers for country and city

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vikktorn/ExampleCountryPicker/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/APa1-tMuiwIK7K59XOvky-2vaU_Ajm0sks5vfz0IgaJpZM4cpp4z .

hvar90 commented 5 years ago

i think you should use this Json data https://raw.githubusercontent.com/David-Haim/CountriesToCitiesJSON/master/countriesToCities.json it is more simple and more complete only the name of the country and the names of the cities me and many people will be very grateful if you could adapt your library only for countries and cities

vikktorn commented 5 years ago

I will do this in next 10 days becouse I currently working on some big project

Viktor Nesic

On Thu, Apr 11, 2019, 5:21 PM Heberth vargas Tello notifications@github.com wrote:

i think you should use this Json data

https://raw.githubusercontent.com/David-Haim/CountriesToCitiesJSON/master/countriesToCities.json it is more simple and more complete only the name of the country and the names of the cities me and many people will be very grateful if you could adapt your library only for countries and cities

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vikktorn/ExampleCountryPicker/issues/4#issuecomment-482159676, or mute the thread https://github.com/notifications/unsubscribe-auth/APa1-tSaRPl1jsZ_7WxACnfcthXAZiu4ks5vf1L_gaJpZM4cpp4z .

hvar90 commented 5 years ago

THANK YOU !!

hvar90 commented 5 years ago

It's a shame this option was never added, it would have been very useful