Paths, JSONKeys should not be in the SBStringConstants

vikmis007 / SurveyBeats

MIT License

0 stars 0 forks source link

Paths, JSONKeys should not be in the SBStringConstants #13

Open dekablade01 opened 5 years ago

dekablade01 commented 5 years ago

Listing constants in a single file is not good at scale. What will happen if you have thousands of models and hundreds of API EndPoint
I don't see PROs listing them in a single file could please explain what's the reason ?

vikmis007 commented 5 years ago

@Dekablade01 Idea behind using them in a single file was that I always create one single constant file for each module and all the constants related to that module should be under one roof. Keeping all the constants intact in one file helps in finding & modifying them if needed at later point of time.

But thanks for providing an insight that constants specific to one particular file (which won't be used anywhere else) should remain coupled in the same file.

vikmis007 commented 5 years ago

@Dekablade01 Refactored string constant file. Changes have been merged to develop branch & will be available in the master branch in next release.