Open Coshibu opened 9 years ago
Hello Coshibu,
Hello vikoadi, Thanks for your feedback. I will implement your suggestions one of these days. This is a fun exercise for me to learn coding, so it might take a while. I will remove the settings menu, although I really would prefer it. I run the indicator in unity and it took me a while to figure out to how to get to the settings. Besides, there are many indicators that have such an entry: Power settings, Sound settings, Time settings, Skype, Owncloud, Dropbox.
Hi Coshibu,
We now have some duplicated code for browse_*
. It will be simpler if you can create a new function public void browse_path (string path)
and call it from respective functions.
to check and and create folder you can create one more function
private bool afford_folder_exist (string path) {
File folder = File.new_for_path (path);
if (!folder.query_exists ())
return folder.make_directory ();
else
return true;
}
and call that function before open_file
and don't forget to change 'home folder' into 'phone storage'
i think thats all, if you have problem don't hesitate to contact me, (but sorry for the downtime if i just give respond after 6 days)
kind regards, Viko Adi R
As I understand it, indicator-kdeconnect is now being maintained on the fork https://github.com/Bajoja/indicator-kdeconnect
Please consider installing that version instead and check whether your pull request still apply and if does submit it there?
Added direct access to home folder, camera folder, pictures folder, Download folder and Music folder.