search

vikoadi / indicator-kdeconnect

AppIndicator for KDE Connect
http://vikoadi.blogspot.com/
Other
117 stars 55 forks source link

KF5-based KDE Connect unsupported #20

Open KAMiKAZOW opened 9 years ago

KAMiKAZOW commented 9 years ago

indicator-kdeconnect seems to not recognize the new KF5-based KDE Connect. I paired my phone from the KF5 KDE Connect KCM. The indicator says "paired but not reachable".

albertvaka commented 9 years ago

A change we made recently broke the DBUS API, sorry and thanks for reporting it! It should be fixed now (see this commit: https://git.reviewboard.kde.org/r/124084/ ) Can you try again with the latest version in master (from the KDE repo, the Github mirror is not updated yet) and see if it's fixed?

@vikoadi It would be nice when you have time to update your code to use pairingChanged(bool paired) instead of pairedSuccessful() and unpaired(), so we can eventually remove these two (we added them back to not break API, but marked them as deprecated). It should be a simple change :)

aleixpol commented 9 years ago

API restored, deprecated. http://commits.kde.org/kdeconnect-kde/ef788e065804383206137377ce740e967866f156

vikoadi commented 9 years ago

@KAMiKAZOW KF5 branch should listen to pairingChanged by now, but as i don’t have KF5 desktop right now i need someone to verify

thanks everyone

albertvaka commented 9 years ago

Good call creating a new branch! I didn't realize before but we need to make sure you don't need to break compatibility with users of the KDE4 version (which probably means most of our users). We will keep the "deprecated" versions long enough so you don't need to worry about this. Thanks!

KAMiKAZOW commented 9 years ago

Forgot to build from the branch. Currently compiling. Will report tomorrow.

albertvaka commented 9 years ago

We also changed the kdeconnect code to not break backwards compatibility (but deprecated the old API), so it should work anyway :P On Jul 5, 2015 7:41 PM, "Markus S." notifications@github.com wrote:

Forgot to build from the branch. Currently compiling. Will report tomorrow.

— Reply to this email directly or view it on GitHub https://github.com/vikoadi/indicator-kdeconnect/issues/20#issuecomment-118698373 .

KAMiKAZOW commented 9 years ago

My devices are listed as "Paired but not reachable", using the KF5 branch by @vikoadi I don't think Fedora ships the modifications by @albertvaka yet.