canvas.save(int) removed in API 28. Solution inside. - Githubissues

vikramkakkar / SublimePicker

A material-styled android view that provisions picking of a date, time & recurrence option, all from a single user-interface.

Apache License 2.0

2.31k stars 407 forks source link

canvas.save(int) removed in API 28. Solution inside. #90

Open gavingt opened 5 years ago

gavingt commented 5 years ago

The following lines use a method which was deprecated in API 26 and removed in API 28. This makes Proguarding this library impossible:

https://github.com/vikramkakkar/SublimePicker/blob/8f573b1cfdff8a5a67f1687934105d4f1c502060/sublimepickerlibrary/src/main/java/com/appeaser/sublimepickerlibrary/timepicker/RadialTimePickerView.java#L704

and

https://github.com/vikramkakkar/SublimePicker/blob/8f573b1cfdff8a5a67f1687934105d4f1c502060/sublimepickerlibrary/src/main/java/com/appeaser/sublimepickerlibrary/timepicker/RadialTimePickerView.java#L713

However, the solution is simple. Just use

canvas.save()

instead of

canvas.save(Canvas.CLIP_SAVE_FLAG);