vikrum / kidpix

JSKIDPIX v1.0.2021
https://kidpix.app/
GNU General Public License v3.0
611 stars 26 forks source link

Blank background saves as gray #21

Open jtrustad opened 3 years ago

jtrustad commented 3 years ago

Hi! The background looks white in my browser (Firefox on MacOS) but when I save the image to my computer, it looks gray instead. If I specifically color an area white, then that area also looks white in the saved image. See images below to see the issue more clearly. Thanks!

Screenshot

kidpix-1629753236690 kidpix-1629753349123

vikrum commented 3 years ago

Hm - this is because it's being saved as a png which supports transparency.

I've had a few questions about this... would it be nicer if it defaulted to jpg which flattens it (i.e. if there's anything transparent, it'll get turned to white) — but if you want the transparent png, I can set it so if you do something like ALT + (save icon) it does png.

matthewgiarra commented 4 months ago

@jtrustad It's not saving with a gray background ... that's just how your image viewer is rendering the transparent background. If you re-save it as jpg or as png without the alpha channel, the background will render white. On Mac preview (since you said you're on mac), do file -> export, select PNG, and uncheck "alpha."

That said, it might not be bad to default to saving without the transparency channel. I suspect most people exporting their kids drawings probably want the export to look like the canvas looked in the browser.