search

vikrum / kidpix

JSKIDPIX v1.0.2021
https://kidpix.app/
GNU General Public License v3.0
611 stars 26 forks source link

Bug: Firecracker eraser conflicts with persistence if the user closes the window/tab #4

Closed ohheyjosh closed 3 years ago

ohheyjosh commented 3 years ago

It looks like the app uses some type of persistence to keep your work if you close the tab or window, but this is conflicting with the firecracker tool if the user exits mid-explosion:

CleanShot 2021-08-05 at 11 24 36

Steps to reproduce:

  1. Create a masterpiece
  2. Select firecracker tool from eraser menu
  3. Apply firecracker to canvas, starting animation sequence
  4. Close the browser tab or window before the animation sequence completes
  5. Reopen browser tab or window

Possible solution: clearing the persistence state at the start of the firecracker animation sequence?

bennett4senate commented 3 years ago

I remember clearly when my friends and I discovered the "secret" that you could pause the firecracker (and other erase functions) mid-erase by pressing a certain button (spacebar maybe?). It seems like @ohheyjosh found it :) I came here to ask that functionality to be restored. Not sure if I should create this as a separate issue?

vikrum commented 3 years ago

Yep, you're both correct! @bennett4senate , you're memory is correct :) I'm part way thru implementing pausing it so that the animation is kept. It'll either be ctrl/alt or one of those modifier keys. I'll get it out later today.

I hope you're enjoying it!

vikrum commented 3 years ago

Deployed pausing the animation! Press Ctrl/Meta to stop it part way thru :)

ohheyjosh commented 3 years ago

Is that deployment live? The steps I described at the top can still be used to reproduce what feels like a bug and not a feature.