vikstrous / Quest-Schedule-Exporter

Allows University of Waterloo students to export their schedules from Quest.
schedule.wattools.com
5 stars 9 forks source link

Fixed the en-US locale handler #6

Closed johnwyz88 closed 10 years ago

johnwyz88 commented 10 years ago

The US locale handler was assumed to work without modification but that's not the case. I have fixed the handler and it should work perfectly now. YYYY/MM/DD was normalized incorrectly to DD/YYYY/MM. PHP only accepts MM/DD/YYYY format by default, and I have changed it to this format. I have conducted tests and it should work now.

vikstrous commented 10 years ago

Okay. I have no way of testing this, so I hope it works.

vikstrous commented 10 years ago

Deployed. Please confirm.

johnwyz88 commented 10 years ago

Confirmed. Work with Chrome, firefox and ie for both en-US and en-CA.

On Mon, Sep 8, 2014 at 9:23 PM, Viktor Stanchev notifications@github.com wrote:

Deployed. Please confirm.

— Reply to this email directly or view it on GitHub https://github.com/vikstrous/Quest-Schedule-Exporter/pull/6#issuecomment-54911746 .