improve tracing - track calling contexts

vikstrous / dataloadgen

An implementation of Facebook's DataLoader in Go

MIT License

69 stars 10 forks source link

improve tracing - track calling contexts #5

Closed gtzo-anchorage closed 2 years ago

gtzo-anchorage commented 2 years ago

Tracks calling contexts, such that Load is now decomposed into spans describing wait time and fetch execution for all callers
Obviously needs a bit of cleanup, but this accomplishes what we wanted, I think

vikstrous commented 2 years ago

For context for anyone looking at this: this is a breaking change, but this module is not v1.0 yes, so it makes sense to allow it. Also, I want to remove the dependency on open telemetry and allow for pluggable middlewares for instrumentation, but that will come as another breaking change later.