vikstrous / pirate-get

A command line interface for The Pirate Bay
GNU Affero General Public License v3.0
337 stars 53 forks source link

Pirate-Get as root #104

Open ourcontact opened 7 years ago

ourcontact commented 7 years ago

Trying to track down why pirate-get fails to get to the point where URL is added to transmission

I added print to verify it was pirate-get that failed to call, rather than transmission that fails to add

if args.output == 'transmission': printer.print('Adding to Transmission') subprocess.call(args.transmission_command + ['--add', url])

When pirate-get is run as root and I select a link by number, pirate-get quietly quits to prompt and I have not tracked down where it is exiting or why.

rnhmjoj commented 7 years ago

I wouldn't know but I strongly advise you to not run it as root: pirate-get is not exactly built with security in mind. Is there any particular reason why you are doing this?

ourcontact commented 7 years ago

It was during testing and I had not made necessary changes for remote file systems by adding a usable group to the cifs file system mount and adding same group to the appropriate users,

In trying to understand the flow of pirate-get I could not track down where/why it exited.

I have changes I have and will continue to make to pirate-get to support my needs including additional filters, non interactive query and by a control script can manage the search and follow up with a download request, or send notification when a previously unavailable package is available, etc.

Understanding when and why the program is exiting is simply part of my decoding of the existing code.

Thanks for the advice though :)

rnhmjoj commented 7 years ago

Ok, I'll look into it when I have some spare time. Anyway your changes look useful: are you interested in publishing or getting some of those merged?

ourcontact commented 7 years ago

Thanks, I would greatly appreciate if someone that had time could help me use git hub appropriately. So many options I am not sure what is the "correct" way to participate and make suggestions, updates, etc. especially without stepping on someone else and staying true to the goal of the original publisher.

I haven't done much with this one yet, but I have been downloading many others and making changes for my use, much easier than writing something from scratch!

I think the only thing I have added here is to "improve" in my opinion, the output so it fits on one screen, dropping the lowest results by adding:: lines = shutil.get_terminal_size((80, 20)).lines and table.end = lines-3 in search_results of print.py