Closed fredefox closed 10 years ago
The installer part looks good.
I admit that I haven't tested the spoofed mirror check thoroughly, but I thought it was right. Do you have an easy way of testing this? The idea was that if we get no matches but we don't see the "No hits" message, we got no results because it was blocked and we should throw an error.
Can you split these two changes into separate branches so I can merge them individually?
You can do something like this to split them up:
git checkout HEAD^
git checkout -b soof-check
git cherry-pick master
git checkout master
git reset --hard HEAD^
I modified the install script because I get a "no such number error" or some some such when you check for sudo. Instead the script just tries to do what is necessary and returns if it fails. Does also clean up.
Also the check for a spoofed address should check if
no_results
istrue
and notfalse