search

vikstrous / pirate-get

A command line interface for The Pirate Bay
GNU Affero General Public License v3.0
338 stars 53 forks source link

rename --port option to --transmission-endpoint #128

Closed rnhmjoj closed 4 years ago

rnhmjoj commented 4 years ago

This is a fix for #127. The current --port/-P options actually can specify both hostname and port (and endpoint) but it's not clear from the pirate-get help.

vikstrous commented 4 years ago

This change is backwards incompatible. I would prefer to keep both flags

bignellrp commented 4 years ago

Hi vikstrous, this is still compatible with port but also supports the use of host and port:

e.g. transmission-port = 192.168.0.21:9091

The current version already supports this but calling it port implies only port is possible.

vikstrous commented 4 years ago

image This is a backwards incompatible change that will break for anyone using the flag / config already. We need to keep both options.

bignellrp commented 4 years ago

ah yes, i see. Can the help just be updated then and the name of the flag stay the same?

rnhmjoj commented 4 years ago

Turns out it's pretty easy to add aliases to argparse arguments, I also added an alias to the transmission-port config option. Now it's backward compatibile.